Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: chrome/browser/ui/startup/startup_browser_creator_impl.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: rebase on dependent patch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/singleton_tabs.cc ('k') | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/startup/startup_browser_creator_impl.cc
diff --git a/chrome/browser/ui/startup/startup_browser_creator_impl.cc b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
index 4a7ada3dedaa62b37c4bcc9fa555c01e66fca406..a083f8cd5c61ed39fb4026cefc0d60f43599ee8b 100644
--- a/chrome/browser/ui/startup/startup_browser_creator_impl.cc
+++ b/chrome/browser/ui/startup/startup_browser_creator_impl.cc
@@ -983,10 +983,11 @@ void StartupBrowserCreatorImpl::AddStartupURLs(
// behavior is desired because completing or skipping the sync promo
// causes a redirect to the NTP.
if (!startup_urls->empty() &&
- startup_urls->at(0) == GURL(chrome::kChromeUINewTabURL))
+ startup_urls->at(0) == chrome::kChromeUINewTabURL) {
startup_urls->at(0) = sync_promo_url;
- else
+ } else {
startup_urls->insert(startup_urls->begin(), sync_promo_url);
+ }
}
}
}
« no previous file with comments | « chrome/browser/ui/singleton_tabs.cc ('k') | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698