Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/utility/importer/bookmarks_file_importer.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)
Patch Set: git cl format Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/importer/bookmarks_file_importer.cc
diff --git a/chrome/utility/importer/bookmarks_file_importer.cc b/chrome/utility/importer/bookmarks_file_importer.cc
index 6e042032dd3dd7a03cda893f454f397f245b6d74..123b87708ff22e5eb8a88ca9009f1f42942e7f0a 100644
--- a/chrome/utility/importer/bookmarks_file_importer.cc
+++ b/chrome/utility/importer/bookmarks_file_importer.cc
@@ -43,7 +43,7 @@ bool CanImportURL(const GURL& url) {
}
// Check if |url| is about:blank.
- if (url == GURL(url::kAboutBlankURL))
+ if (url.spec() == url::kAboutBlankURL)
return true;
// If |url| starts with chrome:// or about:, check if it's one of the URLs
@@ -61,7 +61,7 @@ bool CanImportURL(const GURL& url) {
}
for (int i = 0; i < chrome::kNumberOfChromeDebugURLs; ++i) {
- if (fixed_url == GURL(chrome::kChromeDebugURLs[i]))
+ if (fixed_url.spec() == chrome::kChromeDebugURLs[i])
return true;
}

Powered by Google App Engine
This is Rietveld 408576698