Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Issue 2409423004: PDF: Don't follow redirects in the plugin. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
raymes
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Don't follow redirects in the plugin. The MimeHandler should have done it already. BUG=653749 Committed: https://crrev.com/65c30fee167a96761f0bb9929dc44996d9e546fe Cr-Commit-Position: refs/heads/master@{#427452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pdf/document_loader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
raymes
lgtm - I think we should land this. We should add a test though.
4 years, 1 month ago (2016-10-25 05:46:00 UTC) #6
Lei Zhang
On 2016/10/25 05:46:00, raymes wrote: > lgtm - I think we should land this. We ...
4 years, 1 month ago (2016-10-25 06:00:43 UTC) #7
raymes
> What kind of a test did you have in mind? Something in chrome/ with ...
4 years, 1 month ago (2016-10-25 06:06:21 UTC) #8
raymes
> If we add a hook which allows us to load a custom URL during ...
4 years, 1 month ago (2016-10-25 06:08:30 UTC) #9
Lei Zhang
Assuming we land this, do you have time to work on a test separately? Unfortunately ...
4 years, 1 month ago (2016-10-25 06:11:20 UTC) #10
raymes
Yeah, I'm happy to write a test - I don't think it will be too ...
4 years, 1 month ago (2016-10-25 06:12:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409423004/1
4 years, 1 month ago (2016-10-25 18:08:32 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/283440)
4 years, 1 month ago (2016-10-25 19:14:43 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409423004/1
4 years, 1 month ago (2016-10-25 19:38:20 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-25 20:19:02 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 20:20:43 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65c30fee167a96761f0bb9929dc44996d9e546fe
Cr-Commit-Position: refs/heads/master@{#427452}

Powered by Google App Engine
This is Rietveld 408576698