Move WidgetActivationWaiter to a common place

ui/views/test/widget_test.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/test/widget_test.h"
 
 #include "build/build_config.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/test/native_widget_factory.h"
 #include "ui/views/widget/root_view.h"
@@ skipping 132 matching lines @@
   GetWidget()->Init(params);
   GetWidget()->GetContentsView()->AddChildView(view_);
 }
 
 TestInitialFocusWidgetDelegate::~TestInitialFocusWidgetDelegate() {}
 
 View* TestInitialFocusWidgetDelegate::GetInitiallyFocusedView() {
   return view_;
 }
 
+WidgetActivationWaiter::WidgetActivationWaiter(Widget* widget, bool active)
+    : observed_(false), active_(active) {
+#if defined(OS_WIN)
+  // On Windows, a HWND can receive a WM_ACTIVATE message without the value
+  // of ::GetActiveWindow() updating to reflect that change. This can cause
+  // the active window reported by IsActive() to get out of sync. Usually this
+  // happens after a call to HWNDMessageHandler::Deactivate() which works by
+  // activating some other window, which might be in another application.
+  // Doing this can trigger the native OS activation-blocker, causing the
+  // taskbar icon to flash instead. But since activation of native widgets on
+  // Windows is synchronous, we never have to wait anyway, so it's safe to
+  // return here.
+  if (active == widget->IsActive()) {
+    observed_ = true;
+    return;
+  }
+#endif
+  // Always expect a change for tests using this.
+  EXPECT_NE(active, widget->IsActive());

[sky, 2016/10/12 16:05:43]

I think this is error prone for a general class. You should remove the ifdef
above for all platforms.

[Qiang(Joe) Xu, 2016/10/12 16:55:58]

Done.

+  widget->AddObserver(this);
+}
+
+WidgetActivationWaiter::~WidgetActivationWaiter() {}
+
+void WidgetActivationWaiter::Wait() {
+  if (!observed_)
+    run_loop_.Run();
+}
+
+void WidgetActivationWaiter::OnWidgetActivationChanged(Widget* widget,
+                                                       bool active) {
+  if (active_ != active)
+    return;
+
+  observed_ = true;
+  widget->RemoveObserver(this);
+  if (run_loop_.running())
+    run_loop_.Quit();
+}
+
 }  // namespace test
 }  // namespace views