Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2409423002: Move ENABLE_PEPPER_CDMS to a buildflag header. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
jrummell, jschuh, ddorwin
CC:
chromium-reviews, msramek+watch_chromium.org, droger+watchlist_chromium.org, posciak+watch_chromium.org, blundell+watchlist_chromium.org, nasko+codewatch_chromium.org, agrieve+watch_chromium.org, markusheintz_, mlamouri+watch-media_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, lcwu+watch_chromium.org, sdefresne+watchlist_chromium.org, jam, raymes+watch_chromium.org, eme-reviews_chromium.org, darin-cc_chromium.org, halliwell+watch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, alokp+watch_chromium.org, Dirk Pranke, tfarina, avayvod+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ENABLE_PEPPER_CDMS to a buildflag header. Removes the global build flag and #define and converts to a buildflag header in ppapi/features. A new target "//third_party/widevine/cdm:headers" was added since widevine_cdm_version.h was unreferenced in the build. Given that this file now requires //ppapi/features we really need "gn check" to work on it. I made the existing users of ":version_h" reference this new target which encompasses the public headers of the widevine CDM. TBR=jrummell@chromium.org (original reviewer) TBR=jschuh@chromium.org (render_messages.h owners) TBR=ddorwin@chromium.org (widevine owners) Reland of http://crrev.com/2411433002 with official build fix. Committed: https://crrev.com/c5fcdd0ce8d04569d054322ca21f37272d07005a Cr-Commit-Position: refs/heads/master@{#424687}

Patch Set 1 : Original landing #

Patch Set 2 : Fix and format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -144 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/renderer/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M build/config/features.gni View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_browsertest.cc View 8 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/load_library_perf_test.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 9 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/media/encrypted_media_supported_types_browsertest.cc View 12 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M chrome/common/BUILD.gn View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/chrome_key_systems.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
M chromecast/media/base/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cdm/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/cdm/renderer/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cdm/renderer/external_clear_key_key_system_properties.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.h View 2 chunks +2 lines, -1 line 0 comments Download
M components/cdm/renderer/widevine_key_system_properties.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/BUILD.gn View 3 chunks +3 lines, -1 line 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper_impl.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/cdm/pepper_cdm_wrapper_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/media/cdm/render_cdm_factory.h View 3 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/media/cdm/render_cdm_factory.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M extensions/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 3 chunks +4 lines, -2 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download
M media/base/android/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/key_system_properties.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/key_systems.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/base/key_systems.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M media/base/key_systems_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M media/blink/BUILD.gn View 2 chunks +18 lines, -17 lines 0 comments Download
M media/blink/webcontentdecryptionmodule_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
A ppapi/features/BUILD.gn View 1 1 chunk +15 lines, -0 lines 0 comments Download
A ppapi/features/features.gni View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/widevine/cdm/BUILD.gn View 3 chunks +13 lines, -0 lines 0 comments Download
A third_party/widevine/cdm/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/widevine/cdm/widevine_cdm_common.h View 3 chunks +4 lines, -2 lines 0 comments Download
M tools/gn/docs/cookbook.md View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
brettw
Fix and format
4 years, 2 months ago (2016-10-11 21:47:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409423002/20001
4 years, 2 months ago (2016-10-11 21:48:06 UTC) #5
brettw
Reland of previous patch.
4 years, 2 months ago (2016-10-11 21:48:09 UTC) #6
jrummell
lgtm
4 years, 2 months ago (2016-10-11 22:29:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/314066)
4 years, 2 months ago (2016-10-12 01:50:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409423002/20001
4 years, 2 months ago (2016-10-12 03:30:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-12 07:25:39 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:27:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5fcdd0ce8d04569d054322ca21f37272d07005a
Cr-Commit-Position: refs/heads/master@{#424687}

Powered by Google App Engine
This is Rietveld 408576698