Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2409403002: Issue 27542. Guard against CompilationUnitElement is null in SearchMatch.element getter. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 27542. Guard against CompilationUnitElement is null in SearchMatch.element getter. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/27542 Committed: https://github.com/dart-lang/sdk/commit/56bde6da2884ccfb72436b13a4a41c15f59365d1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -45 lines) Patch
M pkg/analysis_server/lib/src/search/element_references.dart View 5 chunks +21 lines, -40 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine.dart View 2 chunks +19 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-11 21:04:19 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-11 21:07:34 UTC) #2
scheglov
4 years, 2 months ago (2016-10-11 21:09:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
56bde6da2884ccfb72436b13a4a41c15f59365d1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698