Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py

Issue 2409343003: In rebaseline-cl, also rebaseline tests with MISSING results. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
index ecb074aee902e0c580a573bc9110dc60a462e5df..2b559f8e1a7c1c80544e5637f941e1a939086808 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py
@@ -72,6 +72,9 @@ class LayoutTestResult(object):
last_retry_result = self.actual_results().split()[-1]
return last_retry_result in ('TEXT', 'IMAGE', 'IMAGE+TEXT', 'AUDIO')
+ def is_missing_baseline(self):
+ return self._result_dict['actual'] == 'MISSING'
+
# FIXME: This should be unified with ResultsSummary or other NRWT layout tests code
# in the layout_tests package.
@@ -157,5 +160,8 @@ class LayoutTestResults(object):
def unexpected_mismatch_results(self):
return self._filter_tests(lambda r: r.has_mismatch_result() and not r.did_run_as_expected())
+ def missing_results(self):
+ return self._filter_tests(lambda r: r.is_missing_baseline())
+
def didnt_run_as_expected_results(self):
return self._filter_tests(lambda r: not r.did_run_as_expected())
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698