Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2409343003: In rebaseline-cl, also rebaseline tests with MISSING results. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, wkorman
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In rebaseline-cl, also rebaseline tests with MISSING results. Reason: Newly-added tests have the test result MISSING in try jobs; we also want to download new baselines when possible for tests with the actual result MISSING, not just tests with results that don't match existing baselines. In theory this should make it so that when webkit-patch rebaseline-cl is run with no extra args, baselines for newly-added tests should also be downloaded. BUG=654604 Committed: https://crrev.com/aa5cab9d5435feb0098f217286a43f02c63ff182 Cr-Commit-Position: refs/heads/master@{#424568}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -11 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults_unittest.py View 2 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
qyearsley
4 years, 2 months ago (2016-10-11 19:32:21 UTC) #3
wkorman
lgtm
4 years, 2 months ago (2016-10-11 20:10:19 UTC) #4
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-11 21:19:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409343003/1
4 years, 2 months ago (2016-10-11 21:29:47 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 22:19:34 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 22:27:17 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa5cab9d5435feb0098f217286a43f02c63ff182
Cr-Commit-Position: refs/heads/master@{#424568}

Powered by Google App Engine
This is Rietveld 408576698