Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issue 240933002: Extend GCMole to also cover cctest files. (Closed)

Created:
6 years, 8 months ago by Michael Starzinger
Modified:
6 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Extend GCMole to also cover cctest files. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20841

Patch Set 1 #

Patch Set 2 : Fix unsafe call-sites found by GCMole. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -34 lines) Patch
M test/cctest/cctest.gyp View 6 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-heap.cc View 1 5 chunks +33 lines, -21 lines 0 comments Download
M tools/gcmole/gcmole.lua View 2 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 8 months ago (2014-04-17 11:03:16 UTC) #1
rossberg
lgtm
6 years, 8 months ago (2014-04-17 11:13:44 UTC) #2
rossberg
lgtm
6 years, 8 months ago (2014-04-17 11:50:00 UTC) #3
Michael Starzinger
6 years, 8 months ago (2014-04-17 11:57:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20841 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698