Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2409303003: Remove unnecessary dependencies on //third_party/webrtc (Closed)

Created:
4 years, 2 months ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary dependencies on //third_party/webrtc WebRTC is about to clean up a lot of dependencies, among them the monolith 'webrtc' target. All dependencies on it should be replaced by more fine-grained ones. * content/browser/ should get what's necessary via the //third_party/libjingle:libjingle_webrtc target. * content/public/renderer/ doesn't seem to depend on WebRTC at all (I code-searched for includes in that subtree) BUG=webrtc:5716 Committed: https://crrev.com/bf4950db52b2c0721b8f777aa560bc73ceec9bf7 Cr-Commit-Position: refs/heads/master@{#427987}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/renderer/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
kjellander_chromium
4 years, 1 month ago (2016-10-27 05:51:12 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-27 07:45:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409303003/20001
4 years, 1 month ago (2016-10-27 09:16:43 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 10:06:41 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 10:09:11 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf4950db52b2c0721b8f777aa560bc73ceec9bf7
Cr-Commit-Position: refs/heads/master@{#427987}

Powered by Google App Engine
This is Rietveld 408576698