Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2409263004: Fix for issue 27567 (inconsistent handling of invalid -D options (Closed)

Created:
4 years, 2 months ago by siva
Modified:
4 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for issue 27567 (inconsistent handling of invalid -D options BUG=#27567 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/aae051e4c3f82b2aba122af8d3c697cf1ee42771

Patch Set 1 #

Patch Set 2 : Address code review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -14 lines) Patch
M runtime/bin/main.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download
A + tests/standalone/env_test.dart View 1 1 chunk +3 lines, -6 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
siva
4 years, 2 months ago (2016-10-12 19:41:36 UTC) #2
rmacnak
Please add a test. The harness will supply arguments if you include // DartOptions=-Dkey=value -Dkey=value
4 years, 2 months ago (2016-10-12 19:54:37 UTC) #3
siva
4 years, 2 months ago (2016-10-12 23:12:27 UTC) #4
siva
On 2016/10/12 23:12:27, siva wrote: Added a test case.
4 years, 2 months ago (2016-10-12 23:27:23 UTC) #5
rmacnak
lgtm
4 years, 2 months ago (2016-10-13 00:42:48 UTC) #6
siva
4 years, 2 months ago (2016-10-13 01:42:34 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
aae051e4c3f82b2aba122af8d3c697cf1ee42771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698