Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Issue 2409253004: [Merge To M54]arc: Fix race when arc package sync service starts. (Closed)

Created:
4 years, 2 months ago by lgcheng
Modified:
4 years, 2 months ago
Reviewers:
xiyuan, khmel, pavely
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, sync-reviews_chromium.org, Matt Giuca
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge To M54]arc: Fix race when arc package sync service starts. Fix the race which happens between initial packagelist refreshed and sync DataTypeController::OnModelStarted by changing the observer of OnAppInstanceReady() to OnPackageListInitialRefreshed(). BUG=652470 TBR=xiyuan@chromium.org, pavely@chromium.org, khmel@chromium.org Test=Manual Test. Sync service always starts after arc packagelist refreshes correctly. Test=Pass sync integration test. Review-Url: https://codereview.chromium.org/2389763003 Cr-Commit-Position: refs/heads/master@{#423362} (cherry picked from commit 88a14008509adefe2b764ccb573ba629ba68dac5) Committed: https://chromium.googlesource.com/chromium/src/+/e24af55b17c3554262658d03395bc48ca05deb4a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M chrome/browser/sync/test/integration/sync_arc_package_helper.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.cc View 4 chunks +16 lines, -17 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Josh Horwich
4 years, 2 months ago (2016-10-12 00:21:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e24af55b17c3554262658d03395bc48ca05deb4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698