Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2409173005: [wasm] Add a Managed<T> wrapper class for allocating C++ classes that are deleted when the wrapper … (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Add a Managed<T> wrapper class for allocating C++ classes that are deleted when the wrapper is garbage collected. Use sparingly! This doesn't add any really new functionality, other than making it more convenient to do this. This will primarily be used to wrap a WasmModule to be referenced from a JSObject that represents an instance. There is one WasmModule C++ object per parsed WasmModule, so this should not be more than a handful or a few dozen in well-behaved programs. R=rossberg@chromium.org,mlippautz@chromium.org BUG= Committed: https://crrev.com/6d266f0088757d24479197a8c30397976486c292 Cr-Commit-Position: refs/heads/master@{#40346}

Patch Set 1 #

Patch Set 2 : [wasm] Add a Managed<T> wrapper class for allocating C++ classes that are garbage collected. #

Patch Set 3 : [wasm] Add a Managed<T> wrapper class for allocating C++ classes that are garbage collected. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -0 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/wasm/managed.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
M test/cctest/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/wasm/test-managed.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (15 generated)
titzer
4 years, 2 months ago (2016-10-12 11:28:19 UTC) #1
Michael Lippautz
lgtm lgtm
4 years, 2 months ago (2016-10-12 12:03:14 UTC) #8
rossberg
lgtm
4 years, 2 months ago (2016-10-12 12:30:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409173005/40001
4 years, 2 months ago (2016-10-17 09:23:47 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-17 09:28:34 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 09:28:51 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6d266f0088757d24479197a8c30397976486c292
Cr-Commit-Position: refs/heads/master@{#40346}

Powered by Google App Engine
This is Rietveld 408576698