Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2409163002: [heap] Don't read current bucket twice when interating over slot set. (Closed)

Created:
4 years, 2 months ago by Hannes Payer (out of office)
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Don't read current bucket twice when interating over slot set. BUG=chromium:648568 Committed: https://crrev.com/33ca1f5175cd85ba06ea24e23102f5a14ee19c40 Cr-Commit-Position: refs/heads/master@{#40174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/heap/slot-set.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
ulan
lgtm
4 years, 2 months ago (2016-10-11 14:00:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409163002/1
4 years, 2 months ago (2016-10-11 14:05:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 14:26:25 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 14:26:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33ca1f5175cd85ba06ea24e23102f5a14ee19c40
Cr-Commit-Position: refs/heads/master@{#40174}

Powered by Google App Engine
This is Rietveld 408576698