Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2409103005: Remove explicitly setting of allow_lazy_parsing in background-parsing-task.cc (Closed)

Created:
4 years, 2 months ago by Toon Verwaest
Modified:
4 years, 2 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove explicitly setting of allow_lazy_parsing in background-parsing-task.cc This is automatically taken into account in the Parser constructor already BUG=v8:5501 Committed: https://crrev.com/3f8a85cefd132abc3ec1566ac16257db3b1b41e7 Cr-Commit-Position: refs/heads/master@{#40275}

Patch Set 1 #

Patch Set 2 : Make sure to set_allow_lazy_parsing in the background parsing task #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/background-parsing-task.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Toon Verwaest
ptal
4 years, 2 months ago (2016-10-13 13:23:21 UTC) #2
marja
lgtm
4 years, 2 months ago (2016-10-13 13:24:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409103005/1
4 years, 2 months ago (2016-10-13 13:28:25 UTC) #5
marja
lgtm (lbtm)
4 years, 2 months ago (2016-10-13 13:35:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409103005/20001
4 years, 2 months ago (2016-10-13 14:05:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-13 14:50:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 14:51:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3f8a85cefd132abc3ec1566ac16257db3b1b41e7
Cr-Commit-Position: refs/heads/master@{#40275}

Powered by Google App Engine
This is Rietveld 408576698