Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2409103002:
Enable loading.mobile benchmark on Android except reference and webview (Closed)
|
Created:
4 years, 2 months ago by Kunihiko Sakamoto Modified:
4 years, 2 months ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable loading.mobile benchmark on Android except reference and webview
Note to sheriffs: If there are failures/crashes on waterfall bots,
please comment out individual pages in tools/perf/page_sets/loading_mobile.py
instead of disabling the whole benchmark.
BUG=643524, 654215
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/eff0660d223203c7e081c9fbdb7ad0e4cf425d15
Cr-Commit-Position: refs/heads/master@{#424949}
Patch Set 1 #
Messages
Total messages: 32 (23 generated)
Description was changed from ========== Reland "Add loading mobile story set" ========== to ========== Reland "Add loading mobile story set" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== Reland "Add loading mobile story set" CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Reland "Add loading mobile story set" This relands https://crrev.com/2363343003/ that was reverted by https://crrev.com/2409433002/ because of WebView perf bot failures. This CL relands it, disabling the benchmark on webview and reference. BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
Description was changed from ========== Reland "Add loading mobile story set" This relands https://crrev.com/2363343003/ that was reverted by https://crrev.com/2409433002/ because of WebView perf bot failures. This CL relands it, disabling the benchmark on webview and reference. BUG=643524 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Patchset #1 (id:1) has been deleted
ksakamoto@chromium.org changed reviewers: + kouhei@chromium.org, nednguyen@chromium.org
lgtm
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
On 2016/10/12 09:23:14, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... Removed master.tryserver.chromium.perf:android_s5_perf_cq;
The CQ bit was checked by nednguyen@google.com
The CQ bit was unchecked by nednguyen@google.com
Description was changed from ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment out individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment out individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment out individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #1 (id:10008)
Message was sent while issue was closed.
Description was changed from ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment out individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Enable loading.mobile benchmark on Android except reference and webview Note to sheriffs: If there are failures/crashes on waterfall bots, please comment out individual pages in tools/perf/page_sets/loading_mobile.py instead of disabling the whole benchmark. BUG=643524,654215 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/eff0660d223203c7e081c9fbdb7ad0e4cf425d15 Cr-Commit-Position: refs/heads/master@{#424949} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/eff0660d223203c7e081c9fbdb7ad0e4cf425d15 Cr-Commit-Position: refs/heads/master@{#424949} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
