Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2409073003: Add loading mobile benchmark (but disable it) (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add loading mobile benchmark (but disable it) This is a reland of ksakamoto@'s work in https://codereview.chromium.org/2363343003/ THe loading benchmark however is disabled due to crbug.com/654215 ------ This adds a story set and corresponding benchmark for mobile loading performance loading team is interested in. Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNFCI/edit BUG=643524 TBR=kouhei@chromium.org, ksakamoto@chromium.org Committed: https://crrev.com/513268e432c40c7e2f0e5ab40ca8aad499479f41 Cr-Commit-Position: refs/heads/master@{#424415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -21 lines) Patch
M tools/perf/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
A tools/perf/benchmarks/loading.py View 1 chunk +28 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +24 lines, -20 lines 0 comments Download
A tools/perf/page_sets/data/loading_mobile.json View 1 chunk +60 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/loading_mobile_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/data/loading_mobile_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/loading_mobile.py View 1 chunk +122 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409073003/1
4 years, 2 months ago (2016-10-11 12:52:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/84389)
4 years, 2 months ago (2016-10-11 13:01:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409073003/1
4 years, 2 months ago (2016-10-11 13:06:35 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/84396)
4 years, 2 months ago (2016-10-11 13:15:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409073003/1
4 years, 2 months ago (2016-10-11 13:20:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 13:44:01 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 13:45:49 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/513268e432c40c7e2f0e5ab40ca8aad499479f41
Cr-Commit-Position: refs/heads/master@{#424415}

Powered by Google App Engine
This is Rietveld 408576698