MD History: Select items when tapping anywhere inside the item

MD History: Select items when tapping anywhere inside the item

This brings the selection/deselection behavior in line with the old
History page, which allows selection to be toggled when clicking on any
non-interactive part of the item.

BUG=620036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5
Cr-Commit-Position: refs/heads/master@{#429216}

[tsergeant, 2016-10-12 03:31:11]

Description was changed from

==========
MD History: Select items when tapping anywhere inside the item

This brings the selection/deselection behavior in line with the old
History page, which allows selection to be toggled when clicking on any
non-interactive part of the item.

BUG=620036
==========

to

==========
MD History: Select items when tapping anywhere inside the item

This brings the selection/deselection behavior in line with the old
History page, which allows selection to be toggled when clicking on any
non-interactive part of the item.

BUG=620036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-10-12 03:32:01]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 03:32:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 04:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 04:32:06]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-10-12 04:38:35]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2016-10-14 10:56:20]

lgtm w/ question

https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_item_test.js (right):

https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_item_test.js:126:
MockInteractions.tap(item.$['title']);
Does this actually trigger a navigate off the page? Will that mess anything up
(e.g if you added another test below this)?

[tsergeant, 2016-11-02 04:41:35]

https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_h...
File chrome/test/data/webui/md_history/history_item_test.js (right):

https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_h...
chrome/test/data/webui/md_history/history_item_test.js:126:
MockInteractions.tap(item.$['title']);
On 2016/10/14 10:56:20, calamity wrote:
> Does this actually trigger a navigate off the page? Will that mess anything up
> (e.g if you added another test below this)?

...huh, it actually does. I didn't expect MockInteractions to be able to do
that.

I've removed this assertion since it seems like a recipe for disaster, and I
can't think of any other ways to do it.

[tsergeant, 2016-11-02 04:41:44]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-11-02 04:41:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2409063003/#ps40001
(title: "Remove <a> test")

[commit-bot: I haz the power, 2016-11-02 04:41:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 05:43:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 05:45:12]

Description was changed from

==========
MD History: Select items when tapping anywhere inside the item

This brings the selection/deselection behavior in line with the old
History page, which allows selection to be toggled when clicking on any
non-interactive part of the item.

BUG=620036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Select items when tapping anywhere inside the item

This brings the selection/deselection behavior in line with the old
History page, which allows selection to be toggled when clicking on any
non-interactive part of the item.

BUG=620036
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5
Cr-Commit-Position: refs/heads/master@{#429216}
==========

[commit-bot: I haz the power, 2016-11-02 05:45:13]

Patchset 3 (id:??) landed as
https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5
Cr-Commit-Position: refs/heads/master@{#429216}