Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2409063003: MD History: Select items when tapping anywhere inside the item (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 1 month ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Select items when tapping anywhere inside the item This brings the selection/deselection behavior in line with the old History page, which allows selection to be toggled when clicking on any non-interactive part of the item. BUG=620036 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5 Cr-Commit-Position: refs/heads/master@{#429216}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Remove <a> test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -16 lines) Patch
M chrome/browser/resources/md_history/app.crisper.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/app.vulcanized.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.js View 1 1 chunk +15 lines, -6 lines 0 comments Download
M chrome/test/data/webui/md_history/history_item_test.js View 1 2 3 chunks +25 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tsergeant
4 years, 2 months ago (2016-10-12 04:38:35 UTC) #7
calamity
lgtm w/ question https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_history/history_item_test.js File chrome/test/data/webui/md_history/history_item_test.js (right): https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_history/history_item_test.js#newcode126 chrome/test/data/webui/md_history/history_item_test.js:126: MockInteractions.tap(item.$['title']); Does this actually trigger a ...
4 years, 2 months ago (2016-10-14 10:56:20 UTC) #8
tsergeant
https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_history/history_item_test.js File chrome/test/data/webui/md_history/history_item_test.js (right): https://codereview.chromium.org/2409063003/diff/1/chrome/test/data/webui/md_history/history_item_test.js#newcode126 chrome/test/data/webui/md_history/history_item_test.js:126: MockInteractions.tap(item.$['title']); On 2016/10/14 10:56:20, calamity wrote: > Does this ...
4 years, 1 month ago (2016-11-02 04:41:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409063003/40001
4 years, 1 month ago (2016-11-02 04:41:56 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 05:43:02 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 05:45:13 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c48ea42d17c96882f244e047cf2e600ba14ec8f5
Cr-Commit-Position: refs/heads/master@{#429216}

Powered by Google App Engine
This is Rietveld 408576698