Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2409053002: mash: Use null AcceleratedWidget for widgets in tests (Closed)

Created:
4 years, 2 months ago by sadrul
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Use null AcceleratedWidget for widgets in tests When running in tests, the ui::ContextFactory creates test contexts that do not support real GL operations. Some of the code (e.g. InProcessContextProvider) expects a null widget for ui::Compositor::widget() in this situation. So update WindowTreeHostMus to follow this. Also, re-enable the tests, and make sure the test context factory are destroyed correctly during test tear-down. BUG=652871 Committed: https://crrev.com/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2 Cr-Commit-Position: refs/heads/master@{#424515}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M ash/common/wm/workspace/workspace_layout_manager_unittest.cc View 1 3 chunks +0 lines, -16 lines 0 comments Download
M mash/test/mash_test_suite.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/window_tree_host_mus.cc View 1 2 3 3 chunks +18 lines, -7 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
sadrul
4 years, 2 months ago (2016-10-11 15:16:38 UTC) #17
sky
LGTM and thanks for looking at this so quickly.
4 years, 2 months ago (2016-10-11 19:19:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409053002/60001
4 years, 2 months ago (2016-10-11 19:41:28 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-11 19:46:17 UTC) #22
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:48:03 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c2df26e737f98f72f03dfe4ac1fe1ea91545bab2
Cr-Commit-Position: refs/heads/master@{#424515}

Powered by Google App Engine
This is Rietveld 408576698