chrome/browser/resources/settings/site_settings_page/site_settings_page.html - Issue 2409003002: [MD settings] flag to enable site settings All sites and Site details pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Issue 2409003002: [MD settings] flag to enable site settings All sites and Site details pages (Closed)

Patch Set: var name changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/site_settings/site_list.js ('K') | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/browser/resources/settings/site_settings_page/site_settings_page.js » ('j') | chrome/browser/resources/settings/site_settings_page/site_settings_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings_page/site_settings_page.html

diff --git a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

index 930e5e5c7a590ecd5f1ea3457d535b2194fd54a5..71f47ca27a0fc13669e43c8a1a2d437fe23e8170 100644

--- a/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

+++ b/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

@@ -10,13 +10,17 @@

<dom-module id="settings-site-settings-page">

- <div class="settings-box first" category$="[[ALL_SITES]]"

- on-tap="onTapCategory" actionable>

- <iron-icon icon="settings:list"></iron-icon>

- <div class="middle">$i18n{siteSettingsCategoryAllSites}</div>

- <button class="icon-arrow-right" is="paper-icon-button-light"></button>

- </div>

- <div class="settings-box two-line"

+ <template is="dom-if" if="[[enableAllSitesAndDetails_]]">

+ <div class="settings-box first" category$="[[ALL_SITES]]"

+ on-tap="onTapCategory" actionable>

+ <iron-icon icon="settings:list"></iron-icon>

+ <div class="middle">$i18n{siteSettingsCategoryAllSites}</div>

+ <button class="icon-arrow-right" is="paper-icon-button-light"></button>

+ </div>

+ <div class="settings-box line-only"

Dan Beam 2016/10/12 17:54:05 missing ">". does this work?

dschuyler 2016/10/13 01:23:07 It worked, but I think that was just the HMTL pars

+ </div>

+ </template>

+ <div class="settings-box two-line first"

category$="[[ContentSettingsTypes.COOKIES]]" on-tap="onTapCategory"

actionable>

<iron-icon icon="[[computeIconForContentCategory(