[MD settings] flag to enable site settings All sites and Site details pages

[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG=654638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42
Cr-Commit-Position: refs/heads/master@{#425503}

[dschuyler, 2016-10-11 01:24:46]

Description was changed from

==========
[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG=654638
==========

to

==========
[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG=654638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-10-11 01:24:48]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 01:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-11 01:36:28]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 01:36:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-11 01:41:46]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[dschuyler, 2016-10-11 01:41:47]

It's been awhile since I've added a run-time flag. Does it look like I got the
right pieces specified? It does work when I tested it.

[commit-bot: I haz the power, 2016-10-11 01:48:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 01:48:04]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-10-12 17:54:06]

can we just call the code "site settings" when there's actually "sites"?  and
otherwise "content settings" when it deals with content types?

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:310: /*
don't follow this, follow every other comment in this file

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:30:
enableAllSitesAndDetails_: Boolean,
enableAllSitesAndDetails_: {
  type: Boolean,
  value: function() {
    return loadTimeData.getString('enableAllSitesAndDetails');
  },
},

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings_page/site_settings_page.html
(right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.html:20:
<div class="settings-box line-only"
missing ">".  does this work?

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings_page/site_settings_page.js
(right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.js:17:
enableAllSitesAndDetails_: Boolean,
use value: function() { ... },

https://codereview.chromium.org/2409003002/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:251: extern const char
kSiteSettingsAllSitesAndDetails[];
can we just call this EnableSiteSettings?

[dschuyler, 2016-10-12 19:04:27]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[dschuyler, 2016-10-12 19:05:11]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-10-12 19:05:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:08:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[commit-bot: I haz the power, 2016-10-12 19:10:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:10:48]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dschuyler, 2016-10-13 01:21:54]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 01:22:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-13 01:23:07]

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:310: /*
On 2016/10/12 17:54:05, Dan Beam wrote:
> don't follow this, follow every other comment in this file

Done.

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings/site_list.js (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings/site_list.js:30:
enableAllSitesAndDetails_: Boolean,
On 2016/10/12 17:54:05, Dan Beam wrote:
> enableAllSitesAndDetails_: {
>   type: Boolean,
>   value: function() {
>     return loadTimeData.getString('enableAllSitesAndDetails');
>   },
> },

Done.

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/site_settings_page/site_settings_page.html
(right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.html:20:
<div class="settings-box line-only"
On 2016/10/12 17:54:05, Dan Beam wrote:
> missing ">".  does this work?

It worked, but I think that was just the HMTL parser being generous.

Done.

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/site_settings_page/site_settings_page.js
(right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/site_settings_page/site_settings_page.js:17:
enableAllSitesAndDetails_: Boolean,
On 2016/10/12 17:54:06, Dan Beam wrote:
> use value: function() { ... },

Done.

https://codereview.chromium.org/2409003002/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.h (right):

https://codereview.chromium.org/2409003002/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.h:251: extern const char
kSiteSettingsAllSitesAndDetails[];
On 2016/10/12 17:54:06, Dan Beam wrote:
> can we just call this EnableSiteSettings?

Done.

[commit-bot: I haz the power, 2016-10-13 01:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 01:24:29]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Dan Beam, 2016-10-13 04:37:32]

lgtm

https://codereview.chromium.org/2409003002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2409003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:317: /* A
settings-box with no height other than the seprator line. */
separator

[dschuyler, 2016-10-13 18:55:03]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-13 18:55:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-10-13 18:56:15]

https://codereview.chromium.org/2409003002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/2409003002/diff/60001/chrome/browser/resource...
chrome/browser/resources/settings/settings_shared_css.html:317: /* A
settings-box with no height other than the seprator line. */
On 2016/10/13 04:37:32, Dan Beam wrote:
> separator

Done.

[commit-bot: I haz the power, 2016-10-13 20:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 20:14:15]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-10-13 21:11:24]

The CQ bit was checked by dschuyler@chromium.org

[dschuyler, 2016-10-13 21:11:25]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2409003002/#ps80001
(title: "merge with master; fix typo")

[commit-bot: I haz the power, 2016-10-13 21:12:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 21:18:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 21:18:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dschuyler, 2016-10-13 21:36:36]

dschuyler@chromium.org changed reviewers:
+ holte@chromium.org

[dschuyler, 2016-10-13 21:36:37]

holte@ for owner on histograms.xml

[Dan Beam, 2016-10-14 21:33:54]

ping holte@

[Steven Holte, 2016-10-14 21:48:52]

histograms lgtm

[Dan Beam, 2016-10-14 22:02:59]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-10-14 22:03:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 23:03:35]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-10-14 23:05:33]

Description was changed from

==========
[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG=654638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] flag to enable site settings All sites and Site details pages

This CL places the pages for All Sites and Site details behind a flag.

BUG=654638
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42
Cr-Commit-Position: refs/heads/master@{#425503}
==========

[commit-bot: I haz the power, 2016-10-14 23:05:34]

Patchset 4 (id:??) landed as
https://crrev.com/b2bc8c55e0b4e130cd0f8b9e9dae77c3c0134a42
Cr-Commit-Position: refs/heads/master@{#425503}