Issue 2408993002: Fix PushPromiseWaitCancels to call FireAlarm to cancel the promised stream instead of explicitly ca…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2408993002: Fix PushPromiseWaitCancels to call FireAlarm to cancel the promised stream instead of explicitly ca… (Closed)

Created:
4 years, 2 months ago by Zhongyi Shi

Modified:
4 years, 2 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix PushPromiseWaitCancels to call FireAlarm to cancel the promised stream instead of explicitly call Cancel(). relnote: n/a (test only) Merge internal change: 135621462 BUG=

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	net/quic/core/quic_client_promised_info_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Depends on Patchset:

Issue 2408973003 Patch 20001

Dependent Patchsets:

Issue 2409013002 Patch 1

Issue 2409013002 Patch 20001

Messages

Total messages: 4 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages