Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2408893002: skpbench: add debug prints for thermal trip points (Closed)

Created:
4 years, 2 months ago by csmartdalton
Modified:
4 years, 2 months ago
Reviewers:
egdaniel, bsalomon
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

skpbench: add debug prints for thermal trip points Prints thermal trip points that have been exceeded when a HardwareException is raised, and verbosity is set to debug. This can help us correlate thermal trip points with throttling and detect future throttling before it occurs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2408893002 Committed: https://skia.googlesource.com/skia/+/2a9610171b24aca1d1dce085b956572c7b57f183

Patch Set 1 #

Patch Set 2 : skpbench: add warmup run #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -28 lines) Patch
M tools/skpbench/_hardware.py View 2 chunks +5 lines, -1 line 0 comments Download
M tools/skpbench/_hardware_android.py View 2 chunks +26 lines, -1 line 0 comments Download
tools/skpbench/skpbench.cpp View 9 chunks +52 lines, -18 lines 0 comments Download
M tools/skpbench/skpbench.py View 3 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
csmartdalton
4 years, 2 months ago (2016-10-10 21:07:24 UTC) #3
bsalomon
lgtm
4 years, 2 months ago (2016-10-11 16:53:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408893002/1
4 years, 2 months ago (2016-10-11 16:57:42 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 19:15:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2a9610171b24aca1d1dce085b956572c7b57f183

Powered by Google App Engine
This is Rietveld 408576698