Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc

Issue 2408873002: relnote: Deprecate flag quic_no_lower_bw_resumption_limit (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
diff --git a/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc b/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
index 61b7192c8648359fd84f9eb72ff50678fdc97cde..fe036adc22f6af641a1e09148362835f3d7449f9 100644
--- a/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
+++ b/net/quic/core/congestion_control/tcp_cubic_sender_packets_test.cc
@@ -807,18 +807,10 @@ TEST_F(TcpCubicSenderPacketsTest, BandwidthResumption) {
sender_->ResumeConnectionState(cached_network_params, false);
EXPECT_EQ(kMaxCongestionWindowPackets, sender_->congestion_window());
- if (FLAGS_quic_no_lower_bw_resumption_limit) {
- // Resume with an illegal value of 0 and verify the server uses 1 instead.
- cached_network_params.set_bandwidth_estimate_bytes_per_second(0);
- sender_->ResumeConnectionState(cached_network_params, false);
- EXPECT_EQ(sender_->min_congestion_window(), sender_->congestion_window());
- } else {
- cached_network_params.set_bandwidth_estimate_bytes_per_second(
- (kMinCongestionWindowForBandwidthResumption - 1) * kDefaultTCPMSS);
- sender_->ResumeConnectionState(cached_network_params, false);
- EXPECT_EQ(kMinCongestionWindowForBandwidthResumption,
- sender_->congestion_window());
- }
+ // Resume with an illegal value of 0 and verify the server uses 1 instead.
+ cached_network_params.set_bandwidth_estimate_bytes_per_second(0);
+ sender_->ResumeConnectionState(cached_network_params, false);
+ EXPECT_EQ(sender_->min_congestion_window(), sender_->congestion_window());
// Resume to the max value.
cached_network_params.set_max_bandwidth_estimate_bytes_per_second(
« no previous file with comments | « net/quic/core/congestion_control/tcp_cubic_sender_packets.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698