Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2408833002: [inspector] fix minor issue in test/inspector.gyp (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix minor issue in test/inspector.gyp * Inspector should depend on v8_libbase, v8 depedency is added in conditions section. * Inlined sources since they aren't used outside of this gyp file. BUG=chromium:635948 R=dgozman@chromium.org Committed: https://crrev.com/085a445775371cddc30c16840a2056cb0944b369 Cr-Commit-Position: refs/heads/master@{#40139}

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M test/inspector/inspector.gyp View 1 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
kozy
Dmitry, please take a look.
4 years, 2 months ago (2016-10-10 17:44:25 UTC) #1
dgozman
lgtm
4 years, 2 months ago (2016-10-10 18:33:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408833002/20001
4 years, 2 months ago (2016-10-10 18:39:03 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 19:08:29 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 19:08:58 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/085a445775371cddc30c16840a2056cb0944b369
Cr-Commit-Position: refs/heads/master@{#40139}

Powered by Google App Engine
This is Rietveld 408576698