Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 240883003: Introduce exception object and remove some uses of MaybeObject::IsFailure(). (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Introduce exception object and remove some uses of MaybeObject::IsFailure(). R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20871

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -36 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/allocation-site-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/elements.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/heap.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/ic.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M src/isolate.h View 3 chunks +9 lines, -9 lines 0 comments Download
M src/objects.h View 3 chunks +3 lines, -2 lines 0 comments Download
M src/objects-debug.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 8 months ago (2014-04-17 10:27:12 UTC) #1
Benedikt Meurer
lgtm
6 years, 8 months ago (2014-04-18 12:04:40 UTC) #2
Yang
6 years, 8 months ago (2014-04-22 07:33:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20871 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698