Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2408823002: [asmjs] Move switch-logic.h to asmjs/ directory. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
Reviewers:
bradnelson, aseemgarg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asmjs] Move switch-logic.h to asmjs/ directory. R=bradnelson@chromium.org,aseemgarg@chromium.org BUG= Committed: https://crrev.com/d46c790ef35d098451af3e1209a9b7249d2491b1 Cr-Commit-Position: refs/heads/master@{#40135}

Patch Set 1 #

Patch Set 2 : [asmjs] Move switch-logic.h to asmjs/ directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -100 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + src/asmjs/switch-logic.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/asmjs/switch-logic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/v8.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D src/wasm/switch-logic.h View 1 chunk +0 lines, -31 lines 0 comments Download
D src/wasm/switch-logic.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M test/unittests/wasm/switch-logic-unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
titzer
4 years, 2 months ago (2016-10-10 17:27:42 UTC) #1
bradnelson
lgtm
4 years, 2 months ago (2016-10-10 17:33:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408823002/20001
4 years, 2 months ago (2016-10-10 17:33:47 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 17:57:36 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:57:53 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d46c790ef35d098451af3e1209a9b7249d2491b1
Cr-Commit-Position: refs/heads/master@{#40135}

Powered by Google App Engine
This is Rietveld 408576698