Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: chrome/browser/ui/views/tabs/window_finder_ozone.cc

Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 (Closed)
Patch Set: addressed tom's reviews Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/window_finder_ozone.cc
diff --git a/chrome/browser/ui/views/tabs/window_finder_chromeos.cc b/chrome/browser/ui/views/tabs/window_finder_ozone.cc
similarity index 51%
copy from chrome/browser/ui/views/tabs/window_finder_chromeos.cc
copy to chrome/browser/ui/views/tabs/window_finder_ozone.cc
index f4d0f226993aa06f08a2bda9a064c85163100fca..9e3430d568239d8be69e63ffead5b490a80626ee 100644
--- a/chrome/browser/ui/views/tabs/window_finder_chromeos.cc
+++ b/chrome/browser/ui/views/tabs/window_finder_ozone.cc
@@ -1,17 +1,15 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/ui/views/tabs/window_finder.h"
-
-#include "ui/aura/window.h"
+#include <set>
rjkroege 2016/10/25 20:10:40 Can you refactor this to use window_finder_mus? It
tonikitoo 2016/10/26 05:37:17 1st take done in https://codereview.chromium.org/2
-gfx::NativeWindow GetLocalProcessWindowAtPointAsh(
- const gfx::Point& screen_point,
- const std::set<gfx::NativeWindow>& ignore);
+#include "chrome/browser/ui/views/tabs/window_finder.h"
gfx::NativeWindow WindowFinder::GetLocalProcessWindowAtPoint(
const gfx::Point& screen_point,
const std::set<gfx::NativeWindow>& ignore) {
- return GetLocalProcessWindowAtPointAsh(screen_point, ignore);
+ NOTREACHED() << "This should never be reached, but we need "
+ << "a stub implementation to link.";
+ return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698