Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"
 
 #include "chrome/browser/ui/views/frame/browser_frame_mus.h"
 #include "chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.h"
 #include "services/shell/runner/common/client_util.h"
 
 NativeBrowserFrame* NativeBrowserFrameFactory::Create(
     BrowserFrame* browser_frame,
     BrowserView* browser_view) {
   if (shell::ShellIsRemote())
     return new BrowserFrameMus(browser_frame, browser_view);
+
+#if !defined(USE_OZONE)

[rjkroege, 2016/10/11 18:49:47]

this looks strange. i.e.: something is not right here but I'm not the right
person. +sadrul to comment more about how this should fit?

[sadrul, 2016/10/11 19:14:14]

What happens if you use this piece of code with ozone?

[tonikitoo, 2016/10/12 13:44:23]

In patchset #3, in if you look at chrome/browser/ui/BUILD.gn ,
views/frame/desktop_browser_frame_auralinux.cc is not built for 'use_ozone'.

Some reasons:

- desktop_browser_frame_auralinux.cc contains some X11 code. Well, we could
maybe ifdef it out, but decided not to for now.

- DesktopBrowserFrameAuraLinux ctor calls out
BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost which is only
implemented for win and x11 in
chrome/browser/ui/views/frame/browser_desktop_window_tree_host_{win,x11}.cc

My understanding is that for "mus" we do not want this method implemented.

All in all, since we are targeting launching with "--mash", we would enter the
"if" clause in line 14 above.

patchset 4 adds NOTREACHED with some text to explain it.

   return new DesktopBrowserFrameAuraLinux(browser_frame, browser_view);
+#else
+  return nullptr;
+#endif
 }