chrome/browser/ui/ozone_stubs.cc - Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ozone_stubs.cc

Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 (Closed)

Patch Set: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/ozone_stubs.h ('k') | chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc » ('j') | chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/base/idle/idle.h"

6

7 #include "base/logging.h"	5 #include "base/logging.h"

	6 #include "chrome/browser/ui/ozone_stubs.h"

8	7

9 namespace ui {	8 namespace ui {

10	9

11 void CalculateIdleTime(IdleTimeCallback notify) {	10 bool GetCustomFramePrefDefault() {

12 NOTIMPLEMENTED();	11 NOTIMPLEMENTED();

13 notify.Run(0);	12 return true;

14 }	13 }

15	14

16 bool CheckIdleStateIsLocked() {	15 } // namespace ui

	16

	17 bool IsFullScreenMode() {
	rjkroege 2016/10/11 18:49:47 this is weird. It should be in an anonymous block? this is weird. It should be in an anonymous block? And it's not used? Delete it? tonikitoo 2016/10/12 13:44:23 Without this stub implementation, I get this: (.. Show quoted text On 2016/10/11 18:49:47, rjkroege wrote: > this is weird. It should be in an anonymous block? And it's not used? Delete it? Without this stub implementation, I get this: (..) chrome/browser/notifications/fullscreen_notification_blocker.cc:49: error: undefined reference to 'IsFullScreenMode()' clang: error: linker command failed with exit code 1 (use -v to see invocation) Also note that there are win, linux/x11, mac and chromeos implementations of this method in: chrome/browser/fullscreen_win.cc chrome/browser/fullscreen_aurax11.cc chrome/browser/fullscreen_mac.mm chrome/browser/fullscreen_chromeos.cc .. and all are implemented in the anonymous namespace. the mash implementation is also missing, and is tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=640390 I am adding chrome/browser/fullscreen_ozone.cc stub'ed out for now.
17 NOTIMPLEMENTED();	18 NOTIMPLEMENTED();

18 return false;	19 return false;

19 }	20 }

20	21

21 } // namespace ui

OLD	NEW