chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc - Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc

Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 (Closed)

Patch Set: addressed sky's review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc ('k') | chrome/browser/ui/views/frame/native_browser_frame_factory_ozone.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"	5 #include "chrome/browser/ui/views/frame/native_browser_frame_factory.h"

6	6

7 #include "chrome/browser/ui/views/frame/browser_frame_mus.h"	7 #include "chrome/browser/ui/views/frame/browser_frame_mus.h"

8 #include "chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.h"	8 #include "chrome/browser/ui/views/frame/desktop_browser_frame_auralinux.h"

9 #include "services/service_manager/runner/common/client_util.h"	9 #include "services/service_manager/runner/common/client_util.h"

10	10

11 NativeBrowserFrame* NativeBrowserFrameFactory::Create(	11 NativeBrowserFrame* NativeBrowserFrameFactory::Create(

12 BrowserFrame* browser_frame,	12 BrowserFrame* browser_frame,

13 BrowserView* browser_view) {	13 BrowserView* browser_view) {

14 if (service_manager::ServiceManagerIsRemote())	14 if (service_manager::ServiceManagerIsRemote())

15 return new BrowserFrameMus(browser_frame, browser_view);	15 return new BrowserFrameMus(browser_frame, browser_view);

	16 #if defined(USE_OZONE)
	sky 2016/11/07 17:18:52 You shouldn't need this ifdef anymore, right? You shouldn't need this ifdef anymore, right? tonikitoo 2016/11/07 17:22:18 Sorry, forgot to git add the change locally. It is Show quoted text On 2016/11/07 17:18:52, sky wrote: > You shouldn't need this ifdef anymore, right? Sorry, forgot to git add the change locally. It is gone.
	17 NOTREACHED() << "For Ozone builds, only --mash launch is supported for now.";

	18 return nullptr;

	19 #else

16 return new DesktopBrowserFrameAuraLinux(browser_frame, browser_view);	20 return new DesktopBrowserFrameAuraLinux(browser_frame, browser_view);

	21 #endif

17 }	22 }

OLD	NEW