chrome/browser/media/webrtc/window_icon_util_ozone.cc - Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/webrtc/window_icon_util_ozone.cc

Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 (Closed)

Patch Set: addressed tom's reviews Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/fullscreen_ozone.cc ('K') | « chrome/browser/fullscreen_ozone.cc ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/views/frame/native_browser_frame_factory_auralinux.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/media/webrtc/window_icon_util.h"	5 #include "chrome/browser/media/webrtc/window_icon_util.h"

6	6

7 #include "content/public/browser/desktop_media_id.h"	7 #include "content/public/browser/desktop_media_id.h"

8 #include "ui/aura/client/aura_constants.h"	8 #include "ui/aura/client/aura_constants.h"

9 #include "ui/aura/window.h"

10	9

11 gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) {	10 gfx::ImageSkia GetWindowIcon(content::DesktopMediaID id) {

12 DCHECK_EQ(content::DesktopMediaID::TYPE_WINDOW, id.type);	11 DCHECK_EQ(content::DesktopMediaID::TYPE_WINDOW, id.type);
	rjkroege 2016/10/25 20:10:39 forthcoming changes in the mash/aura client code s forthcoming changes in the mash/aura client code should make this unnecessary?
13 aura::Window* window = content::DesktopMediaID::GetAuraWindowById(id);	12 // TODO(tonikitoo): can we make the implementation of

14 if (!window)	13 // chrome/browser/media/webrtc/window_icon_util_chromeos.cc generic

15 return gfx::ImageSkia();	14 // enough so we can reuse it here?

16	15 NOTIMPLEMENTED();

17 const gfx::ImageSkia* icon_image_ptr =	16 return gfx::ImageSkia();

18 window->GetProperty(aura::client::kWindowIconKey);

19

20 return icon_image_ptr ? *icon_image_ptr : gfx::ImageSkia();

21 }	17 }

OLD	NEW