chrome/browser/fullscreen_ozone.cc - Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/fullscreen_ozone.cc

Issue 2408803002: Make it possible to launch chrome --mash with ozone_platform={wayland|x11}, chromeos=0 (Closed)

Patch Set: addressed tom's reviews Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "base/logging.h"

	6

	7 bool IsFullScreenMode() {
	rjkroege 2016/10/25 20:10:39 This can be refactored out of existence: rename fu This can be refactored out of existence: rename fullscreen_chromeos.cc to fullscreen_ozone.cc. And you'll get the correct behaviour. tonikitoo 2016/10/26 05:37:17 1st take done in https://codereview.chromium.org/2 Show quoted text On 2016/10/25 20:10:39, rjkroege wrote: > This can be refactored out of existence: rename fullscreen_chromeos.cc to > fullscreen_ozone.cc. And you'll get the correct behaviour. 1st take done in https://codereview.chromium.org/2453703002
	8 NOTIMPLEMENTED();

	9 // TODO(tonikitoo): Verify if mus has something that can be reused here:

	10 // https://bugs.chromium.org/p/chromium/issues/detail?id=640390

	11 return false;

	12 }

OLD	NEW