Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2408793002: RecreateSKPs: Don't download and use the .boto file (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

RecreateSKPs: Don't download and use the .boto file It's not needed for the new bucket. BUG=skia:5843 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2408793002 Committed: https://skia.googlesource.com/skia/+/76bcd4f189b43e0235e496c0eddf7b3e9f4167f5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -88 lines) Patch
M infra/bots/recipes/swarm_RecreateSKPs.py View 1 3 chunks +1 line, -30 lines 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Nightly-RecreateSKPs_Canary.json View 2 chunks +0 lines, -29 lines 0 comments Download
M infra/bots/recipes/swarm_RecreateSKPs.expected/Housekeeper-Weekly-RecreateSKPs.json View 2 chunks +0 lines, -29 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
borenet
The ~/.boto file still seems to get used; I'm going to delete it on all ...
4 years, 2 months ago (2016-10-10 17:07:26 UTC) #3
rmistry
lgtm https://codereview.chromium.org/2408793002/diff/1/infra/bots/recipes/swarm_RecreateSKPs.py File infra/bots/recipes/swarm_RecreateSKPs.py (right): https://codereview.chromium.org/2408793002/diff/1/infra/bots/recipes/swarm_RecreateSKPs.py#newcode125 infra/bots/recipes/swarm_RecreateSKPs.py:125: recreate_skps_env = {} Delete these 2 lines and ...
4 years, 2 months ago (2016-10-10 17:09:29 UTC) #4
borenet
https://codereview.chromium.org/2408793002/diff/1/infra/bots/recipes/swarm_RecreateSKPs.py File infra/bots/recipes/swarm_RecreateSKPs.py (right): https://codereview.chromium.org/2408793002/diff/1/infra/bots/recipes/swarm_RecreateSKPs.py#newcode125 infra/bots/recipes/swarm_RecreateSKPs.py:125: recreate_skps_env = {} On 2016/10/10 17:09:29, rmistry wrote: > ...
4 years, 2 months ago (2016-10-10 17:17:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408793002/20001
4 years, 2 months ago (2016-10-10 17:18:05 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:37:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/76bcd4f189b43e0235e496c0eddf7b3e9f4167f5

Powered by Google App Engine
This is Rietveld 408576698