Factoring out device affinity generation to be used in swarming

Factoring out device affinity generation to be used in swarming

BUG=chromium:633253
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a9abd484739dad1c6744a00dbe392b9a5b3fe4da

[eyaich1, 2016-10-10 17:03:13]

eyaich@chromium.org changed reviewers:
+ nednguyen@google.com

[nednguyen, 2016-10-10 17:05:47]

On 2016/10/10 17:03:14, eyaich1 wrote:

To be honest, all the logic related to sharding & bot stuffs in benchmark_runner
should be moved to tools/perf/core/..

With this CL, are you planning to have code in tools/perf reusing this method?

[eyaich1, 2016-10-10 17:07:25]

On 2016/10/10 17:05:47, nednguyen wrote:
> On 2016/10/10 17:03:14, eyaich1 wrote:
> 
> To be honest, all the logic related to sharding & bot stuffs in
benchmark_runner
> should be moved to tools/perf/core/..
> 
> With this CL, are you planning to have code in tools/perf reusing this method?

Yes, I was trying to have this logic only in one place.  If we move it to
tools/perf/core, how would telemetry access it?  Or are you saying have it in
two places until we can get rid of it in benchmark_runner?

[nednguyen, 2016-10-10 17:16:39]

On 2016/10/10 17:07:25, eyaich1 wrote:
> On 2016/10/10 17:05:47, nednguyen wrote:
> > On 2016/10/10 17:03:14, eyaich1 wrote:
> > 
> > To be honest, all the logic related to sharding & bot stuffs in
> benchmark_runner
> > should be moved to tools/perf/core/..
> > 
> > With this CL, are you planning to have code in tools/perf reusing this
method?
> 
> Yes, I was trying to have this logic only in one place.  If we move it to
> tools/perf/core, how would telemetry access it?  Or are you saying have it in
> two places until we can get rid of it in benchmark_runner?

Yeah, I worry about keeping the hacky dependency. Or another way is to add s.t
like telemetry/bots_util.py that contains all the logic around bot stuffs. Once
we move everything to swarming & able to kill support for generating the json
list of benchmark in telemetry, we can migrate bots_util to tools/perf/..

[eyaich1, 2016-10-10 18:03:58]

Done.

[nednguyen, 2016-10-10 18:35:45]

lgtm

[eyaich1, 2016-10-10 18:36:21]

The CQ bit was checked by eyaich@chromium.org

[commit-bot: I haz the power, 2016-10-10 18:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 19:00:10]

Description was changed from

==========
Factoring out device affinity generation to be used in swarming

BUG=chromium:633253
==========

to

==========
Factoring out device affinity generation to be used in swarming

BUG=chromium:633253

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-10 19:00:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...