Make BluetoothDevice.uuids attribute deprecated

Make BluetoothDevice.uuids attribute deprecated

This CL adds code to deprecate BluetoothDevice.uuids attribute.

BUG=653317
Committed: https://crrev.com/6c71ae2c347a5b0e6b6be2b8a3e461feb7532c43
Cr-Commit-Position: refs/heads/master@{#424815}

[juncai, 2016-10-10 23:58:27]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 23:58:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[juncai, 2016-10-11 00:00:02]

juncai@chromium.org changed reviewers:
+ ortuno@chromium.org

[juncai, 2016-10-11 00:00:03]

Please take a look.

[commit-bot: I haz the power, 2016-10-11 00:02:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 00:02:06]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[juncai, 2016-10-11 00:38:54]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 00:39:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-10-11 00:50:42]

lgtm

https://codereview.chromium.org/2408773003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2408773003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:468: return
"BluetoothDevice.uuids attribute is deprecated, replace it with "
nit: "BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to retrieve
all available UUIDs."

[commit-bot: I haz the power, 2016-10-11 02:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:02:51]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-11 17:15:24]

juncai@chromium.org changed reviewers:
+ dcheng@chromium.org, isherman@chromium.org

[juncai, 2016-10-11 17:15:25]

dcheng@chromium.org: Please review changes in 
//third_party/WebKit/Source/core/frame/

isherman@chromium.org: Please review changes in 
//tools/metrics/histograms/histograms.xml

[dcheng, 2016-10-11 17:25:19]

//third_party/WebKit/Source/core/frame lgtm

[juncai, 2016-10-11 17:30:57]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[juncai, 2016-10-11 17:31:46]

https://codereview.chromium.org/2408773003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2408773003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:468: return
"BluetoothDevice.uuids attribute is deprecated, replace it with "
On 2016/10/11 00:50:42, ortuno wrote:
> nit: "BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to
retrieve
> all available UUIDs."

Done.

[commit-bot: I haz the power, 2016-10-11 17:32:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:34:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:34:33]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[juncai, 2016-10-11 17:43:57]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 17:44:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 17:53:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 17:53:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Ilya Sherman, 2016-10-11 23:50:46]

histograms.xml lgtm

[juncai, 2016-10-11 23:57:05]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-10-11 23:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2408773003/#ps60001
(title: "merge master and resolve conflicts")

[commit-bot: I haz the power, 2016-10-11 23:57:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 00:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 00:02:35]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[juncai, 2016-10-12 17:25:20]

The CQ bit was checked by juncai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 17:25:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:11:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-12 19:11:09]

Dry run: This issue passed the CQ dry run.

[juncai, 2016-10-12 19:12:35]

The CQ bit was checked by juncai@chromium.org

[juncai, 2016-10-12 19:12:36]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
isherman@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2408773003/#ps80001
(title: "merge master and resolve conflicts")

[commit-bot: I haz the power, 2016-10-12 19:13:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:20:01]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-12 19:21:35]

Description was changed from

==========
Make BluetoothDevice.uuids attribute deprecated

This CL adds code to deprecate BluetoothDevice.uuids attribute.

BUG=653317
==========

to

==========
Make BluetoothDevice.uuids attribute deprecated

This CL adds code to deprecate BluetoothDevice.uuids attribute.

BUG=653317

Committed: https://crrev.com/6c71ae2c347a5b0e6b6be2b8a3e461feb7532c43
Cr-Commit-Position: refs/heads/master@{#424815}
==========

[commit-bot: I haz the power, 2016-10-12 19:21:37]

Patchset 5 (id:??) landed as
https://crrev.com/6c71ae2c347a5b0e6b6be2b8a3e461feb7532c43
Cr-Commit-Position: refs/heads/master@{#424815}

[Jeffrey Yasskin, 2016-10-12 21:37:17]

jyasskin@chromium.org changed reviewers:
+ jyasskin@chromium.org

[Jeffrey Yasskin, 2016-10-12 21:37:18]

https://codereview.chromium.org/2408773003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2408773003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return
"BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to "
I forgot to mention this, but we should include a removal date on all
deprecations. We don't have a chromestatus link, so we can't use
willBeRemoved(), but we can use milestoneString(M57) to get the right date.

[juncai, 2016-10-12 21:49:52]

https://codereview.chromium.org/2408773003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2408773003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:465: return
"BluetoothDevice.uuids is deprecated. Use getPrimaryServices() to "
On 2016/10/12 21:37:18, Jeffrey Yasskin wrote:
> I forgot to mention this, but we should include a removal date on all
> deprecations. We don't have a chromestatus link, so we can't use
> willBeRemoved(), but we can use milestoneString(M57) to get the right date.

Thanks! I'll create a CL to add the removal date.