Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 2408743003: Merge to M53: Android accessibility actions inside iframes not sent to right frame (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2785_124
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/browser_accessibility_manager_android.cc
diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc
index cdb5bbbd84f1c1012e5b50cdf26111a5081544c8..8eba8783185354af7ded8041032f3f30a6cffa7b 100644
--- a/content/browser/accessibility/browser_accessibility_manager_android.cc
+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc
@@ -599,7 +599,7 @@ void BrowserAccessibilityManagerAndroid::Click(JNIEnv* env,
jint id) {
BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
if (node)
- DoDefaultAction(*node);
+ node->manager()->DoDefaultAction(*node);
}
void BrowserAccessibilityManagerAndroid::Focus(JNIEnv* env,
@@ -607,7 +607,7 @@ void BrowserAccessibilityManagerAndroid::Focus(JNIEnv* env,
jint id) {
BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
if (node)
- SetFocus(*node);
+ node->manager()->SetFocus(*node);
}
void BrowserAccessibilityManagerAndroid::Blur(
@@ -621,8 +621,10 @@ void BrowserAccessibilityManagerAndroid::ScrollToMakeNodeVisible(
const JavaParamRef<jobject>& obj,
jint id) {
BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
- if (node)
- ScrollToMakeVisible(*node, gfx::Rect(node->GetLocation().size()));
+ if (node) {
+ node->manager()->ScrollToMakeVisible(
+ *node, gfx::Rect(node->GetLocation().size()));
+ }
}
void BrowserAccessibilityManagerAndroid::SetTextFieldValue(
@@ -632,7 +634,7 @@ void BrowserAccessibilityManagerAndroid::SetTextFieldValue(
const JavaParamRef<jstring>& value) {
BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
if (node) {
- BrowserAccessibilityManager::SetValue(
+ node->manager()->SetValue(
*node, base::android::ConvertJavaStringToUTF16(env, value));
}
}
@@ -645,7 +647,7 @@ void BrowserAccessibilityManagerAndroid::SetSelection(
jint end) {
BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
if (node)
- SetTextSelection(*node, start, end);
+ node->manager()->SetTextSelection(*node, start, end);
}
jboolean BrowserAccessibilityManagerAndroid::AdjustSlider(
@@ -676,7 +678,7 @@ jboolean BrowserAccessibilityManagerAndroid::AdjustSlider(
value += (increment ? delta : -delta);
value = std::max(std::min(value, max), min);
if (value != original_value) {
- BrowserAccessibilityManager::SetValue(
+ node->manager()->SetValue(
*node, base::UTF8ToUTF16(base::DoubleToString(value)));
return true;
}
@@ -888,8 +890,14 @@ void BrowserAccessibilityManagerAndroid::SetAccessibilityFocus(
JNIEnv* env,
const JavaParamRef<jobject>& obj,
jint id) {
- if (delegate_)
- delegate_->AccessibilitySetAccessibilityFocus(id);
+ BrowserAccessibilityAndroid* node = GetFromUniqueID(id);
+ if (!node)
+ return;
+
+ if (node->manager()->delegate()) {
+ node->manager()->delegate()->AccessibilitySetAccessibilityFocus(
+ node->GetId());
+ }
}
bool BrowserAccessibilityManagerAndroid::IsSlider(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698