net/http/http_stream_factory_impl_unittest.cc - Issue 240873003: Create WebSocketTransportClientSocketPool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_unittest.cc

Issue 240873003: Create WebSocketTransportClientSocketPool (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_unittest.cc

diff --git a/net/http/http_stream_factory_impl_unittest.cc b/net/http/http_stream_factory_impl_unittest.cc

index 924e1c3997624dc62d6fd26e9ce456b85927475f..8a407e5015d76d9f6ddb7264236e7ea33f4bf343 100644

--- a/net/http/http_stream_factory_impl_unittest.cc

+++ b/net/http/http_stream_factory_impl_unittest.cc

@@ -945,9 +945,6 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketBasicHandshakeStream) {

session->GetTransportSocketPool(HttpNetworkSession::NORMAL_SOCKET_POOL)));

EXPECT_EQ(0, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::NORMAL_SOCKET_POOL)));

- EXPECT_EQ(1, GetSocketPoolGroupCount(

- session->GetTransportSocketPool(

- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

EXPECT_EQ(0, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

EXPECT_TRUE(waiter.used_proxy_info().is_direct());

@@ -997,9 +994,6 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketBasicHandshakeStreamOverSSL) {

EXPECT_EQ(0, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::NORMAL_SOCKET_POOL)));

EXPECT_EQ(1, GetSocketPoolGroupCount(

- session->GetTransportSocketPool(

- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

- EXPECT_EQ(1, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

EXPECT_TRUE(waiter.used_proxy_info().is_direct());

}

@@ -1162,9 +1156,6 @@ TEST_P(HttpStreamFactoryTest, RequestWebSocketSpdyHandshakeStreamButGetSSL) {

EXPECT_EQ(0, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::NORMAL_SOCKET_POOL)));

EXPECT_EQ(1, GetSocketPoolGroupCount(

- session->GetTransportSocketPool(

- HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

- EXPECT_EQ(1, GetSocketPoolGroupCount(

session->GetSSLSocketPool(HttpNetworkSession::WEBSOCKET_SOCKET_POOL)));

EXPECT_TRUE(waiter1.used_proxy_info().is_direct());

}