Create WebSocketTransportClientSocketPool

base/containers/linked_list.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_CONTAINERS_LINKED_LIST_H_
 #define BASE_CONTAINERS_LINKED_LIST_H_
 
+#include "base/macros.h"
+
 // Simple LinkedList type. (See the Q&A section to understand how this
 // differs from std::list).
 //
 // To use, start by declaring the class which will be contained in the linked
 // list, as extending LinkNode (this gives it next/previous pointers).
 //
 //   class MyNodeType : public LinkNode<MyNodeType> {
 //     ...
 //   };
 //
@@ skipping 81 matching lines @@
     this->next_ = e->next_;
     this->previous_ = e;
     e->next_->previous_ = this;
     e->next_ = this;
   }
 
   // Remove |this| from the linked list.
   void RemoveFromList() {
     this->previous_->next_ = this->next_;
     this->next_->previous_ = this->previous_;
+    this->next_ = NULL;
+    this->previous_ = NULL;

[tyoshino (SeeGerritForStatus), 2014/05/22 06:04:01]

use 0 or NULL for both initializer list and here?

btw, what is this change for? debugging?

[Adam Rice, 2014/05/22 06:49:07]

Okay, I changed the initialisers to use NULL for style-guide compliance.

This change provides the invariant that next() and previous() are non-NULL if
and only if the node is not in a list, which my code depends on. I have added a
comment and a test.

   }
 
   LinkNode<T>* previous() const {
     return previous_;
   }
 
   LinkNode<T>* next() const {
     return next_;
   }
 
   // Cast from the node-type to the value type.
   const T* value() const {
     return static_cast<const T*>(this);
   }
 
   T* value() {
     return static_cast<T*>(this);
   }
 
  private:
   LinkNode<T>* previous_;
   LinkNode<T>* next_;
+
+  DISALLOW_COPY_AND_ASSIGN(LinkNode);
 };
 
 template <typename T>
 class LinkedList {
  public:
   // The "root" node is self-referential, and forms the basis of a circular
   // list (root_.next() will point back to the start of the list,
   // and root_->previous() wraps around to the end of the list).
   LinkedList() : root_(&root_, &root_) {}
 
   // Appends |e| to the end of the linked list.
   void Append(LinkNode<T>* e) {
     e->InsertBefore(&root_);
   }
 
   LinkNode<T>* head() const {
     return root_.next();
   }
 
   LinkNode<T>* tail() const {
     return root_.previous();
   }
 
   const LinkNode<T>* end() const {
     return &root_;
   }
 
+  bool empty() const { return head() == end(); }
+
  private:
   LinkNode<T> root_;
+
+  DISALLOW_COPY_AND_ASSIGN(LinkedList);
 };
 
 }  // namespace base
 
 #endif  // BASE_CONTAINERS_LINKED_LIST_H_