Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2408713004: Updated build files for Fuchsia. (Closed)

Created:
4 years, 2 months ago by P.Y.L.
Modified:
4 years, 2 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org, abarth, jamesr1
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk/@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Only kept typed_mock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
A + pkg/typed_mock/BUILD.gn View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
P.Y.L.
4 years, 2 months ago (2016-10-11 01:27:49 UTC) #3
pquitslund
LGTM
4 years, 2 months ago (2016-10-11 13:32:06 UTC) #4
abarth-chromium
4 years, 2 months ago (2016-10-11 19:17:19 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
34f1501149f7508e7eba170c77b252297b445aaf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698