Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: media/gpu/v4l2_video_decode_accelerator.h

Issue 2408703002: V4L2VideoDecodeAccelerator: implement flush by VIDIOC_DECODER_CMD. (Closed)
Patch Set: add V4L2_DEC_CMD_START back because it works now Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/v4l2_video_decode_accelerator.h
diff --git a/media/gpu/v4l2_video_decode_accelerator.h b/media/gpu/v4l2_video_decode_accelerator.h
index fe15d6f0b69d1b72115f1970cabb9c30e81c7d28..f4ee615427803a515fa1f5649fda9c4cd085bd2a 100644
--- a/media/gpu/v4l2_video_decode_accelerator.h
+++ b/media/gpu/v4l2_video_decode_accelerator.h
@@ -290,6 +290,8 @@ class MEDIA_GPU_EXPORT V4L2VideoDecodeAccelerator
// called any time a relevant queue could potentially be emptied: see
// function definition.
void NotifyFlushDoneIfNeeded();
+ // Returns true if V4L2_DEC_CMD_STOP is supported.
+ bool IsDecoderCmdSupported();
// Reset() task. Drop all input buffers. If V4L2VDA is not doing resolution
// change or waiting picture buffers, call FinishReset.
@@ -449,8 +451,14 @@ class MEDIA_GPU_EXPORT V4L2VideoDecodeAccelerator
int decoder_decode_buffer_tasks_scheduled_;
// Picture buffers held by the client.
int decoder_frames_at_client_;
+
// Are we flushing?
bool decoder_flushing_;
+ // True if V4L2_DEC_CMD_STOP are supported.
Pawel Osciak 2016/10/19 09:23:04 s/V4L2_DEC_CMD_STOP/VIDIOC_DECODER_CMD/ ? s/are/is
wuchengli 2016/10/20 10:14:06 Done.
+ bool decoder_cmd_supported_;
+ // True if flushing is waiting for last output buffer.
Pawel Osciak 2016/10/19 09:23:05 It would be great to add a bit more documentation
wuchengli 2016/10/20 10:14:06 Done.
+ bool flush_waiting_last_output_buffer_;
Pawel Osciak 2016/10/19 09:23:05 Nit: s/waiting/awaiting/
wuchengli 2016/10/20 10:14:06 Done.
+
// Got a reset request while we were performing resolution change or waiting
// picture buffers.
bool reset_pending_;

Powered by Google App Engine
This is Rietveld 408576698