Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2408643002: Remove unused pre-material NTP styling. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused pre-material NTP styling. BUG=625658 Committed: https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628 Cr-Commit-Position: refs/heads/master@{#424140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -140 lines) Patch
D chrome/android/java/res/drawable/bg_ntp_search_box.xml View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_layout.xml View 1 chunk +10 lines, -6 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_recycler_view.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/res/layout/new_tab_page_view.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPage.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageView.java View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java View 5 chunks +3 lines, -32 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageToolbar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 3 chunks +4 lines, -3 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/ntp/NtpStyleUtils.java View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressIndicatorView.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/util/ColorUtils.java View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/android/chrome_feature_list.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/android/logo_service.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-10 10:29:03 UTC) #4
Bernhard Bauer
LGTM!
4 years, 2 months ago (2016-10-10 13:36:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408643002/1
4 years, 2 months ago (2016-10-10 13:38:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 13:43:32 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 13:45:35 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4a1aa1c66e22b57962ad79f66a2c3735b4ed8628
Cr-Commit-Position: refs/heads/master@{#424140}

Powered by Google App Engine
This is Rietveld 408576698