Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2408633003: Tweaks for MockSdk and test ContextBuilder.findSdk() and dart:html. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweaks for MockSdk and test ContextBuilder.findSdk() and dart:html. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8760cb6edf8e870ad255f58887d94f148b97cef9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -6 lines) Patch
M pkg/analyzer/test/src/context/builder_test.dart View 2 chunks +24 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 4 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-10 17:22:37 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-10 17:29:11 UTC) #2
scheglov
4 years, 2 months ago (2016-10-10 17:59:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8760cb6edf8e870ad255f58887d94f148b97cef9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698