Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2408633002: [build] Make Android builds depend on catapult for using the test runner. (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Make Android builds depend on catapult for using the test runner. Costs ~600MB, but only if target_os is android - and the android_tools already require ~7.4GB. BUG=chromium:654353 NOTRY=true Committed: https://crrev.com/1bcb42ae36eeec733b198d966741afc20fd3fd53 Cr-Commit-Position: refs/heads/master@{#40115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M DEPS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Achenbach
PTAL
4 years, 2 months ago (2016-10-10 08:33:20 UTC) #3
tandrii_google
lgtm
4 years, 2 months ago (2016-10-10 08:55:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408633002/1
4 years, 2 months ago (2016-10-10 09:45:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 09:47:53 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 09:48:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bcb42ae36eeec733b198d966741afc20fd3fd53
Cr-Commit-Position: refs/heads/master@{#40115}

Powered by Google App Engine
This is Rietveld 408576698