chrome/browser/plugins/chrome_plugin_service_filter.cc - Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/chrome_plugin_service_filter.cc

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)

Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/chrome_plugin_service_filter.cc

diff --git a/chrome/browser/plugins/chrome_plugin_service_filter.cc b/chrome/browser/plugins/chrome_plugin_service_filter.cc

index e6d8d46e6f37b76b25a0c3aabc93358548492329..9ff1bc7f6231948689a05fc036279f3ef2f2ebed 100644

--- a/chrome/browser/plugins/chrome_plugin_service_filter.cc

+++ b/chrome/browser/plugins/chrome_plugin_service_filter.cc

@@ -223,7 +223,7 @@ bool ChromePluginServiceFilter::IsPluginAvailable(

ContentSetting flash_setting = PluginUtils::GetFlashPluginContentSetting(

settings_map, main_frame_origin, plugin_content_url, &is_managed);

flash_setting = PluginsFieldTrial::EffectiveContentSetting(

- CONTENT_SETTINGS_TYPE_PLUGINS, flash_setting);

+ settings_map, CONTENT_SETTINGS_TYPE_PLUGINS, flash_setting);

double engagement = SiteEngagementService::GetScoreFromSettings(

settings_map, main_frame_origin.GetURL());