chrome/browser/ui/views/website_settings/website_settings_popup_view.cc - Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)

Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/website_settings/website_settings_popup_view.h ('k') | chrome/browser/ui/website_settings/permission_menu_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

diff --git a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

index 2d848a1d49e9ac38f158263bd431d2874a77640f..a5d7499c75057c69a5189b63941ef7cb7236f01d 100644

--- a/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

+++ b/chrome/browser/ui/views/website_settings/website_settings_popup_view.cc

@@ -451,6 +451,7 @@ WebsiteSettingsPopupView::WebsiteSettingsPopupView(

const security_state::SecurityStateModel::SecurityInfo& security_info)

: content::WebContentsObserver(web_contents),

BubbleDialogDelegateView(anchor_view, views::BubbleBorder::TOP_LEFT),

+ profile_(profile),

header_(nullptr),

separator_(nullptr),

site_settings_view_(nullptr),

@@ -687,6 +688,7 @@ void WebsiteSettingsPopupView::SetPermissionInfo(

for (const auto& permission : permission_info_list) {

layout->StartRow(1, content_column);

PermissionSelectorRow* selector = new PermissionSelectorRow(

+ profile_,

web_contents() ? web_contents()->GetVisibleURL() : GURL::EmptyGURL(),

permission);

selector->AddObserver(this);