Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3255)

Unified Diff: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)
Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
diff --git a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
index 7045b6cf219a066dae2f2932bfa0131c476846f2..79d19ab655c4a25005adf02af7132efb23d29ab0 100644
--- a/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
+++ b/chrome/browser/ui/views/website_settings/permission_prompt_impl.cc
@@ -64,7 +64,8 @@ class PermissionCombobox : public views::MenuButton,
virtual void PermissionSelectionChanged(int index, bool allowed) = 0;
};
- PermissionCombobox(Listener* listener,
+ PermissionCombobox(Profile* profile,
+ Listener* listener,
int index,
const GURL& url,
ContentSetting setting);
@@ -89,7 +90,8 @@ class PermissionCombobox : public views::MenuButton,
std::unique_ptr<views::MenuRunner> menu_runner_;
};
-PermissionCombobox::PermissionCombobox(Listener* listener,
+PermissionCombobox::PermissionCombobox(Profile* profile,
+ Listener* listener,
int index,
const GURL& url,
ContentSetting setting)
@@ -97,6 +99,7 @@ PermissionCombobox::PermissionCombobox(Listener* listener,
index_(index),
listener_(listener),
model_(new PermissionMenuModel(
+ profile,
url,
setting,
base::Bind(&PermissionCombobox::PermissionChanged,
@@ -245,7 +248,7 @@ PermissionsBubbleDialogDelegateView::PermissionsBubbleDialogDelegateView(
requests[index]->ShouldShowPersistenceToggle();
if (requests.size() > 1) {
PermissionCombobox* combobox = new PermissionCombobox(
- this, index, requests[index]->GetOrigin(),
+ owner->GetProfile(), this, index, requests[index]->GetOrigin(),
accept_state[index] ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);
row_layout->AddView(combobox);
customize_comboboxes_.push_back(combobox);
@@ -483,3 +486,7 @@ void PermissionPromptImpl::Deny() {
if (delegate_)
delegate_->Deny();
}
+
+Profile* PermissionPromptImpl::GetProfile() {
+ return browser_->profile();
+}

Powered by Google App Engine
This is Rietveld 408576698