Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)
Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
index 078212964fbb8d5867387dc9e3960a857d5ea3d4..641109bd1fe011fb01a7bce2db1ca9bac5656c01 100644
--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller_unittest.mm
@@ -10,6 +10,9 @@
#include "base/macros.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "content/public/test/test_web_contents_factory.h"
#include "net/test/test_certificate_data.h"
#include "testing/gtest_mac.h"
@@ -131,7 +134,8 @@ class WebsiteSettingsBubbleControllerTest : public CocoaTest {
[controller_ setDefaultWindowWidth:default_width];
[controller_ initWithParentWindow:test_window()
websiteSettingsUIBridge:bridge_
- webContents:nil
+ webContents:web_contents_factory_.CreateWebContents(
+ &profile_)
url:GURL("https://www.google.com")
isDevToolsDisabled:NO];
window_ = [controller_ window];
@@ -202,6 +206,10 @@ class WebsiteSettingsBubbleControllerTest : public CocoaTest {
bridge_->SetPermissionInfo(permission_info_list, chosen_object_info_list);
}
+ content::TestBrowserThreadBundle thread_bundle_;
+ TestingProfile profile_;
+ content::TestWebContentsFactory web_contents_factory_;
+
WebsiteSettingsBubbleControllerForTesting* controller_; // Weak, owns self.
NSWindow* window_; // Weak, owned by controller.
};

Powered by Google App Engine
This is Rietveld 408576698