chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h - Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)

Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/website_settings/permission_selector_button_unittest.mm ('k') | chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

index e354afe73d7c5d56011dd426fe0fa6c51f9a4913..6648b95213d7ad9fa43d2b56e25af8fd383a2118 100644

--- a/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

@@ -13,6 +13,7 @@

#include "components/security_state/security_state_model.h"

#include "content/public/browser/web_contents_observer.h"

+class Profile;

class WebsiteSettingsUIBridge;

namespace content {

@@ -32,6 +33,8 @@ class X509Certificate;

@private

content::WebContents* webContents_;

+ Profile* profile_;

tapted 2016/10/11 00:24:50 It's usually nice to avoid unnecessary weak pointe

raymes 2016/10/11 02:04:37 Done.

base::scoped_nsobject<NSView> contentView_;

// The main content view for the Permissions tab.

@@ -103,6 +106,7 @@ class X509Certificate;

- (id)initWithParentWindow:(NSWindow*)parentWindow

websiteSettingsUIBridge:(WebsiteSettingsUIBridge*)bridge

webContents:(content::WebContents*)webContents

+ profile:(Profile*)profile

url:(const GURL&)url

isDevToolsDisabled:(BOOL)isDevToolsDisabled;