Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Side by Side Diff: chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.h

Issue 2408613002: Replace kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… (Closed)
Patch Set: Replace remaining kPreferHtmlOverPlugins feature checks with PluginUtils::ShouldPreferHtmlOverPlugi… Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/mac/scoped_nsobject.h" 9 #include "base/mac/scoped_nsobject.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #import "chrome/browser/ui/cocoa/base_bubble_controller.h" 11 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"
12 #include "chrome/browser/ui/website_settings/website_settings_ui.h" 12 #include "chrome/browser/ui/website_settings/website_settings_ui.h"
13 #include "components/security_state/security_state_model.h" 13 #include "components/security_state/security_state_model.h"
14 #include "content/public/browser/web_contents_observer.h" 14 #include "content/public/browser/web_contents_observer.h"
15 15
16 class Profile;
16 class WebsiteSettingsUIBridge; 17 class WebsiteSettingsUIBridge;
17 18
18 namespace content { 19 namespace content {
19 class WebContents; 20 class WebContents;
20 } 21 }
21 22
22 namespace net { 23 namespace net {
23 class X509Certificate; 24 class X509Certificate;
24 } 25 }
25 26
26 // This NSWindowController subclass manages the InfoBubbleWindow and view that 27 // This NSWindowController subclass manages the InfoBubbleWindow and view that
27 // are displayed when the user clicks the favicon or security lock icon. 28 // are displayed when the user clicks the favicon or security lock icon.
28 // 29 //
29 // TODO(palmer): Normalize all WebsiteSettings*, SiteSettings*, PageInfo*, et c. 30 // TODO(palmer): Normalize all WebsiteSettings*, SiteSettings*, PageInfo*, et c.
30 // to OriginInfo*. 31 // to OriginInfo*.
31 @interface WebsiteSettingsBubbleController : BaseBubbleController { 32 @interface WebsiteSettingsBubbleController : BaseBubbleController {
32 @private 33 @private
33 content::WebContents* webContents_; 34 content::WebContents* webContents_;
34 35
36 Profile* profile_;
37
groby-ooo-7-16 2016/10/10 05:50:07 nit: kill the blank lines
raymes 2016/10/10 06:02:17 Done.
35 base::scoped_nsobject<NSView> contentView_; 38 base::scoped_nsobject<NSView> contentView_;
36 39
37 // The main content view for the Permissions tab. 40 // The main content view for the Permissions tab.
38 NSView* securitySectionView_; 41 NSView* securitySectionView_;
39 42
40 // Displays the short security summary for the page 43 // Displays the short security summary for the page
41 // (private/not private/etc.). 44 // (private/not private/etc.).
42 NSTextField* securitySummaryField_; 45 NSTextField* securitySummaryField_;
43 46
44 // Displays a longer explanation of the page's security state, and how the 47 // Displays a longer explanation of the page's security state, and how the
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // methods on to this class. 99 // methods on to this class.
97 std::unique_ptr<WebsiteSettingsUIBridge> bridge_; 100 std::unique_ptr<WebsiteSettingsUIBridge> bridge_;
98 } 101 }
99 102
100 // Designated initializer. The controller will release itself when the bubble 103 // Designated initializer. The controller will release itself when the bubble
101 // is closed. |parentWindow| cannot be nil. |webContents| may be nil for 104 // is closed. |parentWindow| cannot be nil. |webContents| may be nil for
102 // testing purposes. 105 // testing purposes.
103 - (id)initWithParentWindow:(NSWindow*)parentWindow 106 - (id)initWithParentWindow:(NSWindow*)parentWindow
104 websiteSettingsUIBridge:(WebsiteSettingsUIBridge*)bridge 107 websiteSettingsUIBridge:(WebsiteSettingsUIBridge*)bridge
105 webContents:(content::WebContents*)webContents 108 webContents:(content::WebContents*)webContents
109 forProfile:(Profile*)profile
groby-ooo-7-16 2016/10/10 05:50:07 nit: forProfile
raymes 2016/10/10 06:02:17 Done.
106 url:(const GURL&)url 110 url:(const GURL&)url
107 isDevToolsDisabled:(BOOL)isDevToolsDisabled; 111 isDevToolsDisabled:(BOOL)isDevToolsDisabled;
108 112
109 // Return the default width of the window. It may be wider to fit the content. 113 // Return the default width of the window. It may be wider to fit the content.
110 // This may be overriden by a subclass for testing purposes. 114 // This may be overriden by a subclass for testing purposes.
111 - (CGFloat)defaultWindowWidth; 115 - (CGFloat)defaultWindowWidth;
112 116
113 @end 117 @end
114 118
115 // Provides a bridge between the WebSettingsUI C++ interface and the Cocoa 119 // Provides a bridge between the WebSettingsUI C++ interface and the Cocoa
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 154
151 private: 155 private:
152 // The WebContents the bubble UI is attached to. 156 // The WebContents the bubble UI is attached to.
153 content::WebContents* web_contents_; 157 content::WebContents* web_contents_;
154 158
155 // The Cocoa controller for the bubble UI. 159 // The Cocoa controller for the bubble UI.
156 WebsiteSettingsBubbleController* bubble_controller_; 160 WebsiteSettingsBubbleController* bubble_controller_;
157 161
158 DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsUIBridge); 162 DISALLOW_COPY_AND_ASSIGN(WebsiteSettingsUIBridge);
159 }; 163 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698